Use bool type for simulate_infinite_loop argument of emscripten_set_main_loop
#22540
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set_main_loop` This argument has already been treated as a bool. The change just makes it more clear. Since `bool` (uint8_t) and `int` (int32_t) both compile down to i32 at the wasm level this change won't be backwards compatibility issue for binary object files.
sbc100
changed the title
bool type for simulate_infinite_loop argument of `emscripten_…bool type for simulate_infinite_loop argument of emscripten_set_main_loop
kripken
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument has already been treated as a bool. The change just makes it more clear.
Since
bool(uint8_t) andint(int32_t) both compile down to i32 at the wasm level this change won't be backwards compatibility issue for binary object files.