Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 9, 2024

  • Tabs to spaces
  • And some print status

@sbc100 sbc100 requested a review from kripken September 9, 2024 22:35
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 9, 2024

Because I did a bunch of formatting as well as re-name git doesn't do a good job of showing what actually changed. If you would prefer I can split this into 2 PRs. The first a pure rename, and the second the formatting changes.

@sbc100 sbc100 force-pushed the gcc_tests branch 2 times, most recently from 5876781 to 9537e34 Compare September 9, 2024 23:01
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 9, 2024

I split into 2 commits so git should show the changes better now.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the separate commits, much easier to read that way!

@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 10, 2024

I think I will land this manually rather then squashing, so that both commits are preserved.

sbc100 added a commit that referenced this pull request Sep 10, 2024
- Convert to C
- Tabs to spaces
- And some print status
@sbc100 sbc100 enabled auto-merge (squash) September 10, 2024 18:28
@sbc100 sbc100 disabled auto-merge September 10, 2024 18:28
@sbc100 sbc100 enabled auto-merge (squash) September 10, 2024 18:29
@kripken
Copy link
Member

kripken commented Sep 10, 2024

Squashing is ok here, I think. In the rare event we end up bisecting to this, the original commits are in the PR. But, either way.

@sbc100 sbc100 disabled auto-merge September 10, 2024 21:08
@sbc100 sbc100 merged commit 7ad7f69 into emscripten-core:main Sep 10, 2024
26 of 28 checks passed
@sbc100 sbc100 deleted the gcc_tests branch September 10, 2024 21:08
@sbc100
Copy link
Collaborator Author

sbc100 commented Sep 10, 2024

I landed them separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants