Enable SINGLE_FILE + PTHREADS html output #22547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
pthread_single_file
branch
from
c5af97c to
fe7e58e
Compare
|
My god, what a monstrosity. LGTM. |
juj
approved these changes
Sep 10, 2024
The power of the web! :) I also find this kind of horrifying by I guess we have users that really like shipping just a single file? Do you guys use this feature? |
|
I use SINGLE_FILE in my personal projects and often when bundling test cases to bug trackers. At Unity we did use SINGLE_FILE in a past project, but my understanding is that it is no longer active. The main Unity engine in general does not use SINGLE_FILE, though we do get repeated requests to add support for it, due to ads ecosystem MRAID architecture, which is a "single file" deployment. |
sbc100
force-pushed
the
pthread_single_file
branch
3 times, most recently
from
ab6083f to
9ab991a
Compare
In SINGLE_FILE mode, the JS is inlined directly into the generated HTML. However for pthreads builds we need to be able to create workers that use the same inlined JS. To enable this we encode the JS file into a data URL that can be used for the script `src` attribute. The pthread worker can then use this `src`.
sbc100
force-pushed
the
pthread_single_file
branch
from
9ab991a to
7f67200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SINGLE_FILE mode, the JS is inlined directly into the generated HTML. However for pthreads builds we need to be able to create workers that use the same inlined JS. To enable this we encode the JS file into a data URL that can be used for the script
srcattribute. The pthread worker can then use thissrc.Prior to this change using SINGLE_FILE + PTHREADS + html output would simply fail.