Added some information about 'j' and 'p' types and function signatures #22562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Sep 11, 2024
site/source/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.rst
Outdated
Show resolved
Hide resolved
site/source/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.rst
Outdated
Show resolved
Hide resolved
sbc100
approved these changes
Sep 11, 2024
| added to the table. Otherwise by default the table has a fixed size. | ||
|
|
||
| When using ``addFunction`` on the LLVM Wasm backend, you need to provide | ||
| When using ``addFunction`` with JavaScript function, you need to provide |
There was a problem hiding this comment.
with a JavaScript function?
site/source/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.rst
Outdated
Show resolved
Hide resolved
sbc100
approved these changes
Sep 12, 2024
site/source/docs/porting/connecting_cpp_and_javascript/Interacting-with-code.rst
Outdated
Show resolved
Hide resolved
|
The info on how to use |
|
This change is good to go after a couple of minor fixes. @goldwaving would you have time to look into those? |
|
Should be good to go now. If I missed something, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information needs to be reviewed by someone with deeper knowledge about function signatures, __i53abi, and WASM_BIGINT.