Revert "[tsgen] Handle different get/set types for value_objects too." #22569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
approved these changes
Sep 13, 2024
brendandahl
added a commit
to brendandahl/emscripten
that referenced
this pull request
Sep 18, 2024
In the new TS file we can add tests for things where just checking if the definition file compiles is not enough. This will help catch issues like emscripten-core#22569.
brendandahl
added a commit
that referenced
this pull request
Nov 20, 2024
In the new TS file we can add tests for things where just checking if the definition file compiles is not enough. This will help catch issues like #22569.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #22439
This was working okay for when the user gets a value_object in TS, but when setting a value_object with an object literal this code does not type check correctly. There's an upstream issues about this. I think instead of generating getter/setters we can instead have two type definitions for each value_object. One for reading from TS and one for write from TS. Until I get around to trying that I think we can revert this in the meantime.