Skip to content

Remove a no-longer-needed closure workaround. NFC #22584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
+0 −14
Merged

Remove a no-longer-needed closure workaround. NFC #22584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions src/library_browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ var LibraryBrowser = {
// main loop that is currently allowed to run. All previous main loops
// will quit themselves. This is incremented whenever a new main loop is
// created.
/** @type{number} */
currentlyRunningMainloop: 0,
// The main loop tick function that will be called at each iteration.
func: null,
Expand Down Expand Up @@ -914,20 +913,7 @@ var LibraryBrowser = {
Browser.mainLoop.func = browserIterationFunc;
Browser.mainLoop.arg = arg;

#if MAYBE_CLOSURE_COMPILER
// Closure compiler bug(?): Closure does not see that the assignment
// var thisMainLoopId = Browser.mainLoop.currentlyRunningMainloop
// is a value copy of a number (even with the JSDoc @type annotation)
// but optimizeis the code as if the assignment was a reference assignment,
// which results in Browser.mainLoop.pause() not working. Hence use a
// workaround to make Closure believe this is a value copy that should occur:
// (TODO: Minimize this down to a small test case and report - was unable
// to reproduce in a small written test case)
/** @type{number} */
var thisMainLoopId = (() => Browser.mainLoop.currentlyRunningMainloop)();
#else
var thisMainLoopId = Browser.mainLoop.currentlyRunningMainloop;
#endif
function checkIsRunning() {
if (thisMainLoopId < Browser.mainLoop.currentlyRunningMainloop) {
#if RUNTIME_DEBUG
Expand Down
Loading