[test] Enable --rebaseline with browser reftests. NFC #22600
Merged
+42
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
sbc100
force-pushed
the
reftest_rebase
branch
3 times, most recently
from
d5479d7 to
4045caa
Compare
kripken
approved these changes
Sep 20, 2024
|
Nice idea! |
These allows us to update the reference images quickly and easily directly from the commandline.
sbc100
force-pushed
the
reftest_rebase
branch
from
4045caa to
531d45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These allows us to update the reference images quickly and easily
directly from the commandline.
To test that it works I ran
./test/runner browser.test_webgl_multi_draw_arrays --rebaselineand checked in the resulting change.