[embind] Use std::disjunction for checking policy arguments. #22603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a little cleaner than having to define a recursive template for each of these `is<SomePolicy>`. std::disjunction isn't available until c++17, so I also added a polyfill. I also changed conjunction to use std::conjunction when it is available and polyfill otherwise.
sbc100
reviewed
Sep 20, 2024
| struct isNonnullReturn<> { | ||
| static constexpr bool value = false; | ||
| }; | ||
| using isNonnullReturn = disjunction<std::is_same<nonnull<ret_val>, Policies>...>; |
There was a problem hiding this comment.
Nice!
What are async and non_null in the above lines by the way? Are they special values defines somewhere, or just some kind of placeholder?
There was a problem hiding this comment.
Policy args are basically options you can pass into function bindings. e.g.
function('sleep', &sleep, async());
function('constructor', &constructor, nonnull<ret_val>());
sbc100
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a little cleaner than having to define a recursive template for each of these
is<SomePolicy>. std::disjunction isn't available until c++17, so I also added a polyfill.I also changed conjunction to use std::conjunction when it is available and polyfill otherwise.