Fix -sPROXY_TO_WORKER + -sSINGLE_FILE + node #22610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxyClient needs to jump through a few more hoops here to load the embedded generated JS file which is encoded as a data URL. This change also fixes the mime type used when we embed JS as a data URL.
sbc100
force-pushed
the
node_single_file
branch
from
5a0b5a4 to
438c0fc
Compare
kripken
approved these changes
Sep 24, 2024
| // For class modules we decode the data URL and use `eval: true`. | ||
| url = Buffer.from(url.split(",")[1], 'base64').toString(); | ||
| options ||= {} | ||
| options.eval = true; |
There was a problem hiding this comment.
I did not know this was possible...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxyClient needs to jump through a few more hoops here to load the embedded generated JS file which is encoded as a data URL.
This change also fixes the mime type used when we embed JS as a data URL.