[SjLj] Make Wasm SjLj run with PURE_WASI #22611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `-sPURE_WASI` disabled SjLj support because it uses the JS-based simultion, but accidentally also disabled Wasm SjLj. This makes setting `PURE_WASI` disable SjLj support by default only when Wasm EH is not used. Also this does not force disabling; it only makes the default SjLj setting to be disabled, meaning you can experiment with it if you manually set `-sSUPPORT_LONGJMP` to be other values. Fixes emscripten-core#22566.
sbc100
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
-sPURE_WASIdisabled SjLj support because it uses the JS-based simultion, but accidentally also disabled Wasm SjLj. This makes settingPURE_WASIdisable SjLj support by default only when Wasm EH is not used. Also this does not force disabling; it only makes the default SjLj setting to be disabled, meaning you can experiment with it if you manually set-sSUPPORT_LONGJMPto be other values.Fixes #22566.