Improve test_getaddrinfo. NFC #22639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sbc100
commented
Sep 26, 2024
sbc100
commented
- Add some logging.
- Run the test on desktop to make sure it works there too.
- Add some logging. - Run the test on desktop to make sure it works there too.
sbc100
requested review from
brendandahl and
kripken
and removed request for
kripken
sbc100
commented
Sep 26, 2024
| hints.ai_family = AF_INET6; | ||
| hints.ai_socktype = SOCK_STREAM; | ||
| err = getaddrinfo("www.mozilla.org", "90", &hints, &servinfo); | ||
| err = getaddrinfo("www.google.com", "90", &hints, &servinfo); |
There was a problem hiding this comment.
I changed the address here since www.mozilla.org doesn't have an ipv6 address.
There was a problem hiding this comment.
Huh... that is surprising. But I confirmed and it seems to be the case...
kripken
approved these changes
Sep 26, 2024
| hints.ai_family = AF_INET6; | ||
| hints.ai_socktype = SOCK_STREAM; | ||
| err = getaddrinfo("www.mozilla.org", "90", &hints, &servinfo); | ||
| err = getaddrinfo("www.google.com", "90", &hints, &servinfo); |
There was a problem hiding this comment.
Huh... that is surprising. But I confirmed and it seems to be the case...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.