Add explicit support for localhost DNS lookup
#22641
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also includes a few micro-optimizations for the DNS helpers. Fixes: emscripten-core#22633
sbc100
force-pushed
the
loopback_address
branch
from
ef24ba7 to
abd6526
Compare
kripken
approved these changes
Sep 26, 2024
| res = inetPton6(name); | ||
| if (res !== null) { | ||
| // Unlike the inetPton4 above we don't need and explict null comparison | ||
| // here since there are no valie v6 addresses that are falsey. |
There was a problem hiding this comment.
Suggested change
| // here since there are no valie v6 addresses that are falsey. | |
| // here since there are no valid v6 addresses that are falsey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also includes a few micro-optimizations for the DNS helpers.
Fixes: #22633