Skip to content

[tsgen] Fix braces on ifs for error blocks. #22642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[tsgen] Fix braces on ifs for error blocks. #22642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/embind/embind_gen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,9 @@ var LibraryEmbind = {
}
argStart = 2;
}
if (argsName.length && argsName.length != (argTypes.length - hasThis - 1))
if (argsName.length && argsName.length != (argTypes.length - hasThis - 1)) {
throw new Error('Argument names should match number of parameters.');
}

const args = [];
for (let i = argStart, x = 0; i < argTypes.length; i++) {
Expand Down Expand Up @@ -620,8 +621,9 @@ var LibraryEmbind = {
setterContext) {
fieldName = readLatin1String(fieldName);
const readonly = setter === 0;
if (!(readonly || getterReturnType === setterArgumentType))
if (!(readonly || getterReturnType === setterArgumentType)) {
throw new error('Mismatched getter and setter types are not supported.');
}

whenDependentTypesAreResolved([], [classType], function(classType) {
classType = classType[0];
Expand Down Expand Up @@ -723,8 +725,9 @@ var LibraryEmbind = {
setterContext
) {
const valueArray = tupleRegistrations[rawTupleType];
if (getterReturnType !== setterArgumentType)
if (getterReturnType !== setterArgumentType) {
throw new Error('Mismatched getter and setter types are not supported.');
}

valueArray.elementTypeIds.push(getterReturnType);
},
Expand Down Expand Up @@ -766,8 +769,9 @@ var LibraryEmbind = {
setterContext
) {
const valueObject = structRegistrations[structType];
if (getterReturnType !== setterArgumentType)
if (getterReturnType !== setterArgumentType) {
throw new Error('Mismatched getter and setter types are not supported.');
}

valueObject.fieldTypeIds.push(getterReturnType);
valueObject.fieldNames.push(readLatin1String(fieldName));
Expand Down
Loading