[webgpu] Unknown (undefined) features cause undefined to i32 array writes #22771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
Collaborator
|
@lokokung I think this one is still valid in |
kainino0x
approved these changes
Oct 25, 2024
Collaborator
kainino0x
left a comment
kainino0x
left a comment
There was a problem hiding this comment.
Finally reviewed. LGTM, thank you!
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Oct 25, 2024
- Ports the fix for undefined features from the PR into the new emdawnwebgpu implementation. Change-Id: I1b58532a1de7d4fa52f84bc8f53680ee7867e7b8 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/212334 Reviewed-by: Kai Ninomiya <[email protected]> Commit-Queue: Loko Kung <[email protected]>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 25, 2024
https://dawn.googlesource.com/dawn.git/+log/809e420e990b..655bfce2c235 2024-10-25 [email protected] Default viewFormats to nullptr. 2024-10-25 [email protected] [ir] Add single entry point transform 2024-10-25 [email protected] [dawn][emscripten] Port of emscripten-core/emscripten#22771 2024-10-25 [email protected] [dawn][emscripten] Add bare-bone unit testing for Emscripten bindings. 2024-10-25 [email protected] [dawn][emscripten] Add device lost future getter. 2024-10-25 [email protected] [dawn][emscripten] Use doubles for future ids. 2024-10-25 [email protected] [tint] Fix comment typos 2024-10-25 [email protected] [Kotlin] Fix methods that return containers 2024-10-25 [email protected] [ir] Rename `sampler` in multiplanar transform. 2024-10-25 [email protected] Roll ANGLE from ec262a3243fa to 3a265f143be4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-android-arm-deps-rel;luci.chromium.try:dawn-android-arm64-deps-rel;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-mac-arm64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel;luci.chromium.try:dawn-win11-arm64-deps-rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64 Bug: chromium:369445681,chromium:374691288,chromium:374803367,chromium:375591466 Tbr: [email protected] Test: Test: FeaturesTest Include-Ci-Only-Tests: true Change-Id: I30dd90de328c1f7b1bd8a81c24f0caead3c0c309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5968039 Bot-Commit: chromium-autoroll <[email protected]> Commit-Queue: chromium-autoroll <[email protected]> Cr-Commit-Position: refs/heads/main@{#1374201}
hubot
pushed a commit
to google/skia
that referenced
this pull request
Oct 28, 2024
https://dawn.googlesource.com/dawn.git/+log/809e420e990b..9daf276e5f9a 2024-10-28 [email protected] Roll vulkan-deps from e548898aa37c to 6bf0a68d2621 (1 revision) 2024-10-28 [email protected] Compat CTS: moar expectations cleanup. 2024-10-27 [email protected] Compat CTS: tighten NVidia suppressions. 2024-10-27 dawn-automated-expectations@chops-service-accounts.iam.gserviceaccount.com Roll third_party/webgpu-cts/ 3290214f6..d473d0947 (2 commits) 2024-10-27 [email protected] Roll third_party/webgpu-cts/ ecefa0df4..3290214f6 (7 commits) 2024-10-27 [email protected] Roll vulkan-deps from dcdb07c3662a to e548898aa37c (1 revision) 2024-10-26 [email protected] HLSL-IR: add support for interstage variables 2024-10-26 [email protected] Roll ANGLE from 715fe91d965e to fe99836c8bb8 (1 revision) 2024-10-26 [email protected] Remove redundant constructors 2024-10-26 [email protected] Roll SwiftShader from 145112eea713 to 3aaa6784ca31 (1 revision) 2024-10-26 [email protected] Roll ANGLE from 3a265f143be4 to 715fe91d965e (3 revisions) 2024-10-25 [email protected] Roll vulkan-deps from dd7c0efb9d54 to dcdb07c3662a (11 revisions) 2024-10-25 [email protected] Default viewFormats to nullptr. 2024-10-25 [email protected] [ir] Add single entry point transform 2024-10-25 [email protected] [dawn][emscripten] Port of emscripten-core/emscripten#22771 2024-10-25 [email protected] [dawn][emscripten] Add bare-bone unit testing for Emscripten bindings. 2024-10-25 [email protected] [dawn][emscripten] Add device lost future getter. 2024-10-25 [email protected] [dawn][emscripten] Use doubles for future ids. 2024-10-25 [email protected] [tint] Fix comment typos 2024-10-25 [email protected] [Kotlin] Fix methods that return containers 2024-10-25 [email protected] [ir] Rename `sampler` in multiplanar transform. 2024-10-25 [email protected] Roll ANGLE from ec262a3243fa to 3a265f143be4 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn_Vulkan;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-ASAN_Graphite_Dawn_Metal;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D12;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn_D3D11 Bug: None Tbr: [email protected] Test: Test: FeaturesTest Change-Id: If191c4a0c5a7af23bc8e0678c6c79b8a26e8a832 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/913219 Commit-Queue: skia-autoroll <[email protected]> Bot-Commit: skia-autoroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subj