Remove use of Module['websocket']. NFC
#22774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
websocket_global
branch
2 times, most recently
from
d877393 to
dc4486e
Compare
sbc100
force-pushed
the
websocket_global
branch
from
dc4486e to
2deb831
Compare
kripken
reviewed
Oct 31, 2024
| if (runtimeConfig && null === Module['websocket']['subprotocol']) { | ||
| subProtocols = 'null'; | ||
| opts = undefined; | ||
| } |
Member
There was a problem hiding this comment.
Separate change? (I don't seem to see this code moved anywhere else.)
Collaborator
Author
There was a problem hiding this comment.
I specially handle the === null case above.
We can still receive the initial value for websocket from the Module object but there is not need to continue to access it via the Module object.
sbc100
force-pushed
the
websocket_global
branch
from
2deb831 to
aee468c
Compare
kripken
approved these changes
Oct 31, 2024
| this._callbacks[event].call(this, param); | ||
| } | ||
| }; | ||
| (Module['websocket'] ??= {})['on'] = SOCKFS.on; |
Member
There was a problem hiding this comment.
Do we not need 'emit' as well? Looks like before we had both exported.
Collaborator
Author
There was a problem hiding this comment.
No, I don't think so. The emit for for internal use to send the message. The on is what users would use to register callback.
Collaborator
Author
There was a problem hiding this comment.
You can see that the on property is quoted so that closure won't minify it but the emit helper function is not.
Collaborator
Author
There was a problem hiding this comment.
| if (SOCKFS.websocketArgs['subprotocol']) { | ||
| subProtocols = SOCKFS.websocketArgs['subprotocol']; | ||
| } else if (SOCKFS.websocketArgs['subprotocol'] === null) { | ||
| subProtocols = 'null' |
Member
There was a problem hiding this comment.
Suggested change
| subProtocols = 'null' | |
| subProtocols = 'null'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can still receive the initial value for websocket from the Module object but there is not need to continue to access it via the Module object.