Add missing dependency to emscripten_runtime_keepalive_clear. NFC #22784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
emscripten_runtime_keepalive_clear
branch
from
e3107ba to
9b37362
Compare
Collaborator
Author
kripken
approved these changes
Oct 25, 2024
test/test_other.py
Outdated
| self.do_other_test('test_embool.c') | ||
|
|
||
| def test_strict_closure(self): | ||
| self.emcc(test_file('hello_world.c'), ['-sSTRICT', '--closure=1']) |
Member
There was a problem hiding this comment.
Maybe put it alongside this similar test?
Lines 14906 to 14907 in 9e618aa
eyebrowsoffire
approved these changes
Oct 25, 2024
Collaborator
eyebrowsoffire
left a comment
eyebrowsoffire
left a comment
There was a problem hiding this comment.
LGTM. Just some small suggestions, but they probably don't really matter either way.
| }, | ||
|
|
||
| #if !MINIMAL_RUNTIME | ||
| _emscripten_runtime_keepalive_clear__deps: ['$runtimeKeepaliveCounter'], |
Collaborator
There was a problem hiding this comment.
Two things:
- Perhaps
$runtimeKeepaliveCountershould be removed below from the direct deps ofemscripten_force_exit, since it will already get it implicitly from depending on this function. - I'm not 100% sure about this, but could we instead have an alternative version of
_emscripten_runtime_keepalive_clearthat just doesn't do anything and doesn't depend onruntimeKeepaliveCounterat all, since in that case the variable isn't otherwise used? It doesn't seem to be incremented/decremented or checked in the case I was building. Not a huge deal either way, but if the other code paths avoid using the variable when in this mode, perhaps this one could avoid using the variable as well?
Collaborator
Author
There was a problem hiding this comment.
First part done, good idea.
Second part is harder. Its something I've done for noExitRuntime but this stuff is pretty tricky to get right so I'll leave that for a followup.
sbc100
force-pushed
the
emscripten_runtime_keepalive_clear
branch
from
9b37362 to
ece2b6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22783