Enable auto-merge for bot-created PRs #22788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Oct 25, 2024
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
I guess this still requires a human reviewer right?
Member
Author
|
Yes. |
Member
Author
|
For some reason the PR creation doesn't work in my fork, going to try it on this PR |
Automated changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action Co-authored-by: dschuff <[email protected]>
Reverts #22952 Created by CI error.
Member
Author
|
lol oops, this causes it to actually merge the PR... |
Member
Author
|
OK, I think what actually happened here is that the test PR went to this branch instead of main, and there are no approval requirements for landing on this branch, so it just merged. The behavior I jsut saw on the emsdk side looked right. |
dschuff
added a commit
that referenced
this pull request
Nov 19, 2024
Reverts #22788 Oops, I left my testing code in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still needs a human to approve, but now there's one less button to press.