[library_sockfs] Report socket connect failures via select() #22818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Oct 31, 2024
sbc100
force-pushed
the
socket_error_reporting
branch
from
2670f8e to
a965ee2
Compare
kripken
approved these changes
Oct 31, 2024
When connect fails on a NON_BLOCKING socket the socket is supposed to become writable and the status made available via SO_ERROR. Without this change `test_sockets_echo_client.c` will loop forever polling for read/write status on the socket fd.
sbc100
force-pushed
the
socket_error_reporting
branch
from
a965ee2 to
37819ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connect fails on a NON_BLOCKING socket the socket is supposed to become writable and the status made available via SO_ERROR.
Without this change
test_sockets_echo_client.cwill loop forever polling for read/write status on the socket fd.