Skip to content

implement getentropy via __wasi_random_get. #22819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

implement getentropy via __wasi_random_get. #22819

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbd9450
implement getentropy via __wasi_random_get.
walkingeyerobot Oct 31, 2024
985b7ba
match wasi-libc's implementation
walkingeyerobot Oct 31, 2024
6414b8d
Merge branch 'emscripten-core:main' into main
walkingeyerobot Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system/lib/standalone/standalone.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ weak int __syscall_lstat64(intptr_t path, intptr_t buf) {
// There is no good source of entropy without an import. Make this weak so that
// it can be replaced with a pRNG or a proper import.
Copy link
Collaborator

@sbc100 sbc100 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment can now be removed.

Copy link
Collaborator Author

@walkingeyerobot walkingeyerobot Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

weak int getentropy(void* buffer, size_t length) {
abort();
Copy link
Collaborator

@sbc100 sbc100 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you copy the code from https://github.com/WebAssembly/wasi-libc/blob/main/libc-bottom-half/sources/getentropy.c? (With a link/attribution I think).

Copy link
Collaborator Author

@walkingeyerobot walkingeyerobot Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. should I leave it weak?

return __wasi_random_get(buffer, length);
}

// Emscripten additions
Expand Down
Loading