Avoid reference to SharedArrayBuffer in UTF8ArrayToString #22844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
avoid_SharedArrayBuffer
branch
from
b55621a to
7075487
Compare
kripken
approved these changes
Nov 4, 2024
test/test_other.py
Outdated
| expected = 'pthread_create: environment does not support SharedArrayBuffer, pthreads are not available' | ||
| self.do_runf('hello_world.c', expected, assert_returncode=NON_ZERO, emcc_args=['--pre-js=pre.js']) | ||
| # | ||
| # We specifically test that we can call UTF8ToString which previously contained |
Member
There was a problem hiding this comment.
Suggested change
| # We specifically test that we can call UTF8ToString which previously contained | |
| # We specifically test that we can call UTF8ToString which in earlier Emscripten versions contained |
This allows program built with `SHARED_MEMORY` enabled to run in a single threaded context where `SharedArrayBuffer` is not defined (i.e. when crossOriginIsolated is false). Fixes: emscripten-core#22837
sbc100
force-pushed
the
avoid_SharedArrayBuffer
branch
from
7075487 to
6647b3a
Compare
This was referenced Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows program built with
SHARED_MEMORYenabled to run in a single threaded context whereSharedArrayBufferis not defined (i.e. when crossOriginIsolated is false).Fixes: #22837