Extract JSEvents.memcpy helper. NFC #22846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Nov 4, 2024
Collaborator
Author
|
I notices that were was a bug here in emscripten_get_devicemotion_status and emscripten_get_deviceorientation_status where HEAP32 was used instead of HEAP8. I guess we don't have tests for those! |
Member
|
Hmm, yeah... we might not have tests for these, they might need input faking. We have limited tests for those, sadly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I notices that were was a bug here in
emscripten_get_devicemotion_statusandemscripten_get_deviceorientation_statuswhereHEAP32was used instead ofHEAP8.