Move preloadedAudios/preloadedImages inside Browser. NFC
#22855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
move_preloaded
branch
from
6de65ab to
cd9c4e4
Compare
brendandahl
reviewed
Nov 5, 2024
| path = PATH_FS.resolve(path); | ||
|
|
||
| var canvas = /** @type {HTMLCanvasElement} */(preloadedImages[path]); | ||
| var canvas = /** @type {HTMLCanvasElement} */(Browser.preloadedImages[path]); |
Collaborator
There was a problem hiding this comment.
Missing dependency on $Browser?
Collaborator
Author
There was a problem hiding this comment.
All symbols in this file implicitly depend on $Browser thanks to the autoAddDeps(LibraryBrowser, '$Browser'); line at the bottom.
sbc100
force-pushed
the
move_preloaded
branch
from
cd9c4e4 to
15aee44
Compare
brendandahl
approved these changes
Nov 5, 2024
olilarkin
added a commit
to iPlug2/iPlug2
that referenced
this pull request
Dec 8, 2024
Since emscripten-core/emscripten#22855, preloadedImages is a property of the Browser global which must also now be explicitly included via DEFAULT_LIBRARY_FUNCS_TO_INCLUDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.