[WASM_WORKERS] Ensure TLS is initialized #22856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Nov 5, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
I guess there is no size downside here since that library has a single C file, and is almost always referred to anyhow?
Collaborator
Author
yes, exactly. Passing |
kripken
approved these changes
Nov 5, 2024
The main thread TLS region get initialized via a static constructor in `library_wasm_worker.c`. Without this change programs that don't otherwise reference `library_wasm_worker.c` will not have this static constructor run. Fixes: emscripten-core#22852
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thread TLS region get initialized via a static constructor in
library_wasm_worker.c. Without this change programs that don't otherwise referencelibrary_wasm_worker.cwill not have this static constructor run.Fixes: #22852