WebGPU: Use 32-bit element size for making heap view of requiredFeatures #22868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
jspanchu
changed the title
Collaborator
|
Should the title be "Use 32-bit element size" rather then "Use 32-bit pointer size"? |
sbc100
approved these changes
Nov 6, 2024
jspanchu
changed the title
- This commit fixes adapter.requestDevice for wasm64 by using the correct factor to calculate the end of the view in HEAPU32 from requiredFeaturesPtr. Earlier, the returned array was twice the actual size.
Contributor
Author
|
Yes! updated PR title and commit message. |
sbc100
changed the title
sbc100
changed the title
sbc100
changed the title
Contributor
Author
|
@sbc100 Thanks! will this make it to 3.1.72? |
Collaborator
|
Yup. Or you can try it sooner (in a few hours) using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports https://dawn-review.googlesource.com/c/dawn/+/214094
It fixes
adapter.requestDevicefor wasm64 by using the correct value to calculate the end of the view in HEAPU32 fromrequiredFeaturesPtr. Earlier, the returned array was twice the actual size.