Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Nov 7, 2024

From #22864

@sbc100 sbc100 requested a review from dschuff November 7, 2024 22:29
@dschuff
Copy link
Member

dschuff commented Nov 7, 2024

Maybe it's worth adding the versions of Chrome and firefox that need to be used to work. For chrome this is 132 (flag required, and 132 is currently Canary). Not sure about firefox.

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 8, 2024

Maybe it's worth adding the versions of Chrome and firefox that need to be used to work. For chrome this is 132 (flag required, and 132 is currently Canary). Not sure about firefox.

Since neither browser has yet shipped a version that doesn't require a flag I'm not sure there is much I can say here. They have both always required and a flag and continue to, likely until the new year, right?

@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 8, 2024

I could say "At time of writing all browsers still require a flag to run the resulting binaries but that should change in
the coming months since the propsal is now at stage 4."?

@sbc100 sbc100 requested a review from kripken November 13, 2024 18:39
@sbc100
Copy link
Collaborator Author

sbc100 commented Nov 13, 2024

ping..

This change replaced the usage of the legacy `keyCode` attribute
with the preferred `key` attribute, which also has the advantage of
removing some hardcoded constant numbers.

In order to test this change I fixed the `test_glfw_get_key_stuck`
test and added `test_sdl_key_test` to the interactive tests.

In doing so I noticed and fixed a crash bug that was introduced in emscripten-core#22874.
@sbc100 sbc100 merged commit 04a03f4 into emscripten-core:main Nov 13, 2024
1 of 10 checks passed
@sbc100 sbc100 deleted the changelog_update branch November 13, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants