[test] Unify fake events system. NFC #22915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
unify_fake_events
branch
from
0e24b25 to
eeb306f
Compare
kripken
reviewed
Nov 13, 2024
sbc100
force-pushed
the
unify_fake_events
branch
2 times, most recently
from
b744045 to
e0215ca
Compare
kripken
reviewed
Nov 13, 2024
sbc100
force-pushed
the
unify_fake_events
branch
from
e0215ca to
adef6e7
Compare
Collaborator
Author
|
I refactored this change so that most existing callsites do not need to change. |
kripken
approved these changes
Nov 14, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
lgtm but I would check with all relevant interactive tests before landing.
Collaborator
Author
Actually, I looked through the interactive tests and none of them actually use this stuff, since interactive tests tend to rely on real events not fake ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.