Implement SDL_GetKeyName #22921
Merged
Implement SDL_GetKeyName #22921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
SDL_GetKeyName
branch
from
dc55b05 to
7ff9cc8
Compare
I found this pretty useful during debugging recently.
sbc100
force-pushed
the
SDL_GetKeyName
branch
from
7ff9cc8 to
49c723b
Compare
kripken
approved these changes
Nov 13, 2024
| } | ||
| var size = lengthBytesUTF8(name) + 1; | ||
| SDL.keyName = _realloc(SDL.keyName, size); | ||
| stringToUTF8(name, SDL.keyName, size); |
Member
There was a problem hiding this comment.
Maybe add keyName: 0 to the SDL class for closure? Though if it doesn't error, maybe it doesn't matter.
Collaborator
Author
There was a problem hiding this comment.
I tend to do that kind of thing if (and only if) closure complains.
uysalibov
pushed a commit
to uysalibov/emscripten
that referenced
this pull request
Nov 15, 2024
I found this pretty useful during debugging recently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this pretty useful during debugging recently.