Extract the canvas from the offscreenCanvases entry #22958
Conversation
…reating a context; fixes emscripten-core#22943
|
I added a test that fails without the patch and passes with the patch. |
| @@ -0,0 +1,27 @@ | |||
| // Copyright 2016 The Emscripten Authors. All rights reserved. | |||
|
It looks like this code was added back in 1b27891. It looks like in that original patch this code would have worked because It looks like the breaking change was in 736565e where the values in |
test/test_browser.py
Outdated
| @parameterized({ | ||
| 'offscreencanvas': (['-sOFFSCREENCANVAS_SUPPORT'],), | ||
| 'offscreenframebuffer': (['-sOFFSCREEN_FRAMEBUFFER', '-DUSE_OFFSCREEN_FRAMEBUFFER'],), | ||
| }) |
There was a problem hiding this comment.
Flake8 doesn't like this }). It should be indented to match the @parameterized above.
Sorry for all the back a forth, I think this will be good to go after this fix.
|
Thank you! |
|
Hmm, the code size failures here seem unrelated. @sbc100 was there a recent update there? |
Yup, I just updated the expectation. Rebasing should fix those failures. |
3 participants
Fixes type error in #22943 when creating a context with explicit swap control.