Coding style in library_wasm_worker. NFC #22972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandahl
approved these changes
Nov 20, 2024
Collaborator
brendandahl
left a comment
brendandahl
left a comment
There was a problem hiding this comment.
Aside: it'd be nice if we clang-formatted all our C/C++ code and required it going forward.
Collaborator
Author
Agreed. Although its a little tricky because some of our code is either implicitly or explicitly part of musl which has its own style. Or some other upstream project. So we need to way to declare specifically which stuff is out own internal code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this by hand rather than using clang-format. Its just the indentation and the curly braces on the same line.
Best viewed with "ignore whitespace".