Use JS string templates in library_sockfs.js. NFC #22983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to log the contents of a typed array the old code was doing
`Array.prototype.slice.call(typed_array)` but that doesn't seem
necessary.
```
$ node
> console.log(`hello: ${new Uint8Array(new ArrayBuffer(3))}`);
hello: 0,0,0
> console.log(`hello: ${Array.prototype.slice.call(new Uint8Array(new ArrayBuffer(3)))}`);
hello: 0,0,0
```
sbc100
force-pushed
the
websocket_logging
branch
from
a64ff3c to
511ec7d
Compare
kripken
approved these changes
Nov 21, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Maybe in the far past browsers did not log out elements of typed arrays, but did for JS arrays? Yeah, today it works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to log the contents of a typed array the old code was doing
Array.prototype.slice.call(typed_array)but that doesn't seem necessary.