-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Enable WASM_BIGINT by default #22993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
9eaa392
5532f29
5d13302
152c205
4a6588e
52fedfd
01d5e34
e19febb
2c1b640
c0f2c4a
1f0232b
3cbc37c
b9c8be1
fb50f90
513ce14
8185db1
22165af
dd34e39
166dcc7
3088726
f81e0da
833c212
4004df6
faa22bb
c2627fd
382211e
b05455c
2d5fd55
2cc1703
a8372fc
cb4503e
ed8906a
88775c6
dd73366
b70d46a
2ee2ce3
759de04
f3c20a3
4abe5fb
b7d960a
8a3df8f
d9fb51c
ff8c662
9194564
8e5ba19
02bc462
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1954,10 +1954,8 @@ def test_em_js(self, args, force_c): | |
|
||
@no_wasm2js('WASM_BIGINT is not compatible with wasm2js') | ||
|
||
def test_em_js_i64(self): | ||
err = self.expect_fail([EMCC, '-Werror', test_file('core/test_em_js_i64.c')]) | ||
err = self.expect_fail([EMCC, '-Werror', '-sWASM_BIGINT=0', test_file('core/test_em_js_i64.c')]) | ||
self.assertContained('emcc: error: using 64-bit arguments in EM_JS function without WASM_BIGINT is not yet fully supported: `foo`', err) | ||
|
||
dschuff marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.set_setting('WASM_BIGINT') | ||
self.node_args += shared.node_bigint_flags(self.get_nodejs()) | ||
dschuff marked this conversation as resolved.
Show resolved
Hide resolved
|
||
self.do_core_test('test_em_js_i64.c') | ||
|
||
|
@@ -6995,11 +6993,10 @@ def test_EXPORTED_RUNTIME_METHODS(self): | |
def test_dyncall_specific(self, *args): | ||
if self.get_setting('MEMORY64'): | ||
self.skipTest('not compatible with MEMORY64') | ||
if self.get_setting('WASM_BIGINT'): | ||
# define DYNCALLS because this test does test calling them directly, and | ||
# in WASM_BIGINT mode we do not enable them by default (since we can do | ||
# more without them - we don't need to legalize) | ||
args = list(args) + ['-sDYNCALLS', '-DWASM_BIGINT'] | ||
# define DYNCALLS because this test does test calling them directly, and | ||
# in WASM_BIGINT mode we do not enable them by default (since we can do | ||
# more without them - we don't need to legalize) | ||
args = list(args) + ['-sDYNCALLS', '-DWASM_BIGINT'] | ||
cases = [ | ||
('DIRECT', []), | ||
('DYNAMIC_SIG', ['-sDYNCALLS']), | ||
|
@@ -8417,6 +8414,7 @@ def test_wasm2js(self): | |
if self.is_wasm2js(): | ||
self.skipTest('redundant to test wasm2js in wasm2js* mode') | ||
self.set_setting('WASM', 0) | ||
self.set_setting('WASM_BIGINT', 0) | ||
dschuff marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
self.do_core_test('test_hello_world.c') | ||
self.assertNotExists('test_hello_world.js.mem') | ||
|
||
|
@@ -8448,7 +8446,7 @@ def test_wasm2js_fallback(self, args): | |
if self.is_wasm2js(): | ||
self.skipTest('redundant to test wasm2js in wasm2js* mode') | ||
|
||
cmd = [EMCC, test_file('small_hello_world.c'), '-sWASM=2'] + args | ||
cmd = [EMCC, test_file('small_hello_world.c'), '-sWASM=2', '-sWASM_BIGINT=0'] + args | ||
dschuff marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
self.run_process(cmd) | ||
|
||
# First run with WebAssembly support enabled | ||
|
Uh oh!
There was an error while loading. Please reload this page.