Skip to content

JS file system: distinguish between atime, mtime, and ctime #22998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 4, 2024
Merged

JS file system: distinguish between atime, mtime, and ctime #22998

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
734ed2c
Make chmod not update file access/modification time
hoodmane Nov 25, 2024
3f3f385
Update test
hoodmane Nov 25, 2024
8803db6
Make JS FS support atime, mtime, and ctime as distinct values
hoodmane Nov 26, 2024
f561a5f
Address some review comments
hoodmane Nov 26, 2024
801c284
Shorten code a bit
hoodmane Nov 26, 2024
fe9a17d
Rebaseline code size
hoodmane Nov 26, 2024
170b203
Shorten FSNode code a bit
hoodmane Nov 26, 2024
1ef8734
Revert "Rebaseline code size"
hoodmane Nov 27, 2024
88fdf91
Merge branch 'main' into chmod-not-update-mtim
hoodmane Nov 27, 2024
af80453
Update changelog
hoodmane Nov 27, 2024
54178cf
remove accidentally commited file
hoodmane Nov 27, 2024
713d966
Add PR number to changelog entry
hoodmane Nov 27, 2024
4286b2a
Merge branch 'main' into chmod-not-update-mtim
hoodmane Nov 27, 2024
5e15b42
Remove .timestamp getter/setter
hoodmane Dec 4, 2024
a545108
Merge branch 'main' into chmod-not-update-mtim
hoodmane Dec 4, 2024
52341ed
Merge branch 'main' into chmod-not-update-mtim
hoodmane Dec 4, 2024
cf14591
Fix changelog
hoodmane Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/library_fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,6 @@ FS.staticInit();
}
node.node_ops.setattr(node, {
mode: (mode & {{{ cDefs.S_IALLUGO }}}) | (node.mode & ~{{{ cDefs.S_IALLUGO }}}),
timestamp: Date.now()
});
},
lchmod(path, mode) {
Expand Down
8 changes: 4 additions & 4 deletions test/stat/test_chmod.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ void test() {
memset(&s, 0, sizeof s);
stat("file", &s);
assert(s.st_mode == (0200 | S_IFREG));
assert(s.st_ctime != lastctime);
assert(s.st_ctime == lastctime);

//
// fchmod a file
Expand All @@ -80,7 +80,7 @@ void test() {
memset(&s, 0, sizeof s);
stat("file", &s);
assert(s.st_mode == (0100 | S_IFREG));
assert(s.st_ctime != lastctime);
assert(s.st_ctime == lastctime);


//
Expand All @@ -94,7 +94,7 @@ void test() {
memset(&s, 0, sizeof s);
stat("otherfile", &s);
assert(s.st_mode == (0100 | S_IFREG));
assert(s.st_ctime != lastctime);
assert(s.st_ctime == lastctime);

//
// chmod a folder
Expand All @@ -111,7 +111,7 @@ void test() {
memset(&s, 0, sizeof s);
stat("folder", &s);
assert(s.st_mode == (0300 | S_IFDIR));
assert(s.st_ctime != lastctime);
assert(s.st_ctime == lastctime);

#ifndef WASMFS // TODO https://github.com/emscripten-core/emscripten/issues/15948
//
Expand Down