Skip to content

Fix for core0.test_stat_chmod_rawfs on mac. NFC #23023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix for core0.test_stat_chmod_rawfs on mac. NFC #23023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions test/stat/test_chmod.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ void setup() {
create_file("file", "abcdef", 0777);
create_file("otherfile", "abcdef", 0777);
symlink("file", "file-link");
// some platforms use 777, some use 755 by default for symlinks
// make sure we're using 777 for the test
lchmod("file-link", 0777);
mkdir("folder", 0777);
}

Expand Down Expand Up @@ -113,6 +110,10 @@ void test() {
assert(s.st_ctime != lastctime);

#ifndef WASMFS // TODO https://github.com/emscripten-core/emscripten/issues/15948
lstat("file-link", &s);
int link_mode = s.st_mode;
assert((link_mode & 0777) != S_IRUSR);

//
// chmod a symlink's target
//
Expand All @@ -125,7 +126,7 @@ void test() {

// but the link didn't
lstat("file-link", &s);
assert(s.st_mode == (0777 | S_IFLNK));
assert(s.st_mode == link_mode);

//
// chmod the actual symlink
Expand Down