Add test for GLOBAL_BASE and SIDE_MODULE error message. NFC
#23029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Nov 27, 2024
kripken
reviewed
Nov 27, 2024
| def test_dylink_global_base(self): | ||
| err = self.expect_fail([EMCC, test_file('hello_world.c'), '-sGLOBAL_BASE=1024', '-sMAIN_MODULE']) | ||
| self.assertContained('emcc: error: GLOBAL_BASE is not compatible with relocatable output', err) | ||
|
|
There was a problem hiding this comment.
Testing a side module instead would be faster, and also be future compatible if we ever make main modules non-relocatable. But just a suggestion, lgtm either way.
There was a problem hiding this comment.
The error happens before we do any actual linking work so its just as fast either way.
sbc100
changed the title
GLOBAL_BASE is used with relocatable outputGLOBAL_BASE and SIDE_MODULE error message. NFC
|
Oops it turns out the GLOBAL_BASE does work with MAIN_MODULE since it gets embedded in the JS file. Updated this RP to just a test for the existing error for SIDE_MODULE. |
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…ripten-core#23029) These two options are not compatible, and `GLOBAL_BASE` is currently just ignored in this mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two options are not compatible, and
GLOBAL_BASEis currently just ignored in this mode.