Remove OFFSCREEN_FRAMEBUFFER_FORBID_VAO_PATH. NFC #23056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_test_settings
branch
from
a76ddbe to
6f8d24b
Compare
kainino0x
reviewed
Dec 3, 2024
This was the only remaining test-only setting. The same effect can be achieved instead using some EM_ASM.
sbc100
force-pushed
the
remove_test_settings
branch
from
6f8d24b to
c9f87e8
Compare
|
Updated. PTAL |
|
ping.. |
kripken
reviewed
Dec 5, 2024
|
ping @kainino0x .. |
|
Apologies I was out Thursday/Friday and got super buried in code reviews! |
kainino0x
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the only remaining test-only setting. The same effect can be achieved instead using some EM_ASM.