Error on --emrun with EXIT_RUNTIME=0
#23096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
--emrun requires EXIT_RUNTIME--emrun with EXIT_RUNTIME=0
kripken
reviewed
Dec 9, 2024
The emrun post.js file depend on `addOnExit` to report the exit of the program. We were already forcing `-sEXIT_RUNTIME` but this adds an error if the user tries to explicitly disable it.
sbc100
force-pushed
the
emrun_exit_runtime
branch
from
dca7546 to
38547c8
Compare
kripken
approved these changes
Dec 9, 2024
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
The emrun post.js file depend on `addOnExit` to report the exit of the program. We were already forcing `-sEXIT_RUNTIME` but this adds an error if the user tries to explicitly disable it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emrun post.js file depend on
addOnExitto report the exit of the program. We were already forcing-sEXIT_RUNTIMEbut this adds an error if the user tries to explicitly disable it.