Cleanup test_modularize_init_error. NFC #23105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sbc100
commented
Dec 8, 2024
sbc100
commented
- Use browser_reporting.js directly.
- Delete redundant unhandledrejection handler. browser_reporting handles this already.
- Use browser_reporting.js directly. - Delete redundant unhandledrejection handler. browser_reporting handles this already.
sbc100
force-pushed
the
test_modularize_init_error
branch
from
3f0188c to
9e15ee3
Compare
kripken
approved these changes
Dec 9, 2024
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
- Use browser_reporting.js directly. - Delete redundant unhandledrejection handler. browser_reporting handles this already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.