Wrap runDependencyWatcher in #if ASSERTIONS. NFC
#23111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
runDependencyWatcher
branch
from
c2507a8 to
9f13f99
Compare
brendandahl
approved these changes
Dec 9, 2024
The code that uses `runDependencyWatcher` is only present when assertions are enabled, but the declaration and some usage was not conditional.
sbc100
force-pushed
the
runDependencyWatcher
branch
from
9f13f99 to
2e071bb
Compare
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…3111) The code that uses `runDependencyWatcher` is only present when assertions are enabled, but the declaration and some usage was not conditional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that uses
runDependencyWatcheris only present when assertions are enabled, but the declaration and some usage was not conditional.