Add some slack to test_extern_prepost. NFC #23127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why this would fail on the macOS rollor but not for me locally. |
This test started failing on the macOS roller. The js size on this test on my machine is 5006 which is very close the limit of 100 * 50 that this test was checking against. The main change here is to reduce the limit to from 5k (100 * 50) to 2.5k (50 * 50).
sbc100
force-pushed
the
test_extern_prepost
branch
from
5019931 to
88c7adc
Compare
kripken
approved these changes
Dec 11, 2024
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
This test started failing on the macOS roller. The js size on this test on my machine is 5006 which is very close the limit of 100 * 50 that this test was checking against. The main change here is to reduce the limit to from 5k (100 * 50) to 2.5k (50 * 50).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing on the macOS roller.
The js size on this test on my machine is 5006 which is very close the limit of 100 * 50 that this test was checking against.
The main change here is to reduce the limit to from 5k (100 * 50) to 2.5k (50 * 50).