Rebaseline test_small_js_flags. NFC #23156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
rebaseline_browser_test
branch
from
36af7db to
19c263a
Compare
Also convert to `check_expected_size_in_file` which allows this test to be updated via `--rebaseline` This change shows the incremental progress we've been making on code size recently!
sbc100
force-pushed
the
rebaseline_browser_test
branch
from
19c263a to
ab5297b
Compare
|
I might land this TBR since its currently causing CI to fail. |
|
LGTM, thanks |
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
Also convert to `check_expected_size_in_file` which allows this test to be updated via `--rebaseline` This change shows the incremental progress we've been making on code size recently!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also convert to
check_expected_size_in_filewhich allows this testto be updated via
--rebaselineThis change shows the incremental progress we've been making on code size recently!