Remove createRequire in favor of ES6 import

[sbc100]

No description provided.

[kleisauke]

I think the require() compat function is still needed in some cases.

file:///home/kleisauke/wasm-vips/lib/vips-node.mjs:186
function fd(a,b,c){if(!(0<=a&&3>=a))return 28;if(0===a)a=Date.now();else if(Hi)a=performance.timeOrigin+performance.now();else return 52;D[c>>3]=BigInt(Math.round(1E6*a));return 0}fd.h="iijp";var gd=()=>{};gd.h="v";var jd=a=>x(P(a));jd.h="vp";var kd=()=>{We+=1;throw"unwind";};kd.h="v";var ld=()=>z.length;ld.h="p";var nd=()=>t?require("os").cpus().length:navigator.hardwareConcurrency;nd.h="i";var od=a=>{pi(a)};od.h="vp";
                                                                                                                                                                                                                                                                                                                                      ^

ReferenceError: require is not defined

emscripten/src/library_atomic.js

Lines 155 to 157 in 3d4df5b

	#if ENVIRONMENT_MAY_BE_NODE
	ENVIRONMENT_IS_NODE ? require('os').cpus().length :
	#endif

grep-ing through the codebase, I also found:

emscripten/src/library_uuid.js

Line 36 in 3d4df5b

var rb = require('crypto')['randomBytes'];

emscripten/src/library_wasi.js

Line 582 in 3d4df5b

var crypto_module = require('crypto');

emscripten/src/runtime_shared.js

Line 63 in 3d4df5b

global.performance ??= require('perf_hooks').performance;

emscripten/src/wasm_worker.js

Line 13 in 3d4df5b

var nodeWorkerThreads = require('worker_threads');

emscripten/src/wasm_worker.js

Lines 31 to 32 in 3d4df5b

	var fs = require('fs');
	var vm = require('vm');

etc.

[sbc100]

Oh wow! I guess we don't have tests that cover any of those? Or at least we don't have tests that cover those in combination with EXPORT_ES6.

Lets try to update all those sites rather than being back this pollyfil.

BTW, do you know which of the over usages is the one you are running into?

[kleisauke]

Indeed, I think some test coverage is missing for this. A simple test would be to check whether require( appears in the output JS file, if we proceed with this. It might also cause issues for users who depend on require() in custom --pre-js or --js-library files, but those cases are likely negligible.

BTW, do you know which of the over usages is the one you are running into?

Only the require('os').cpus().length and require('crypto').randomFillSync(view) snippets were causing issues for me.

[sbc100]

Indeed, I think some test coverage is missing for this. A simple test would be to check whether require( appears in the output JS file, if we proceed with this. It might also cause issues for users who depend on require() in custom --pre-js or --js-library files, but those cases are likely negligible.

Presumably any such users would either:

1. Not expect their code to work in an ES6 module context
2. Use createRequire themselves to add require to the ES6 module context.