Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Dec 16, 2024

Reduce confusion by using the correct Ubuntu release name. Currently, the tag is bionic but the image is focal.

-  bionic:
+  focal:
     docker:
       - image: emscripten/emscripten-ci:focal

https://releases.ubuntu.com

Should upgrading to Jammy 22.04 or Noble 24.04 be considered?


Also, resolve four problems raised by the VS Code extension for CircleCI:
image

condition: ${CIRCLE_PULL_REQUEST}
steps:
set-retry-flaky-tests
- set-retry-flaky-tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the old version not work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI flags this as an incorrect data type error which means it could easily stop working in future releases.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but they don't show it as a config error. I wonder why not? LGTM to this part either way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbc100 sbc100 changed the title CircleCI: Ubuntu used is Focal 20.04, not Bionic 18.04 [ci] Update linux image name from bionic to focal Dec 30, 2024
@sbc100 sbc100 merged commit b682a38 into emscripten-core:main Dec 30, 2024
28 checks passed
@cclauss cclauss deleted the CircleCI-which-ubuntu branch December 31, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants