[test] Add new decorators for running tests under different FS backends #23177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
hoodmane
reviewed
Dec 16, 2024
hoodmane
reviewed
Dec 16, 2024
hoodmane
reviewed
Dec 16, 2024
hoodmane
approved these changes
Dec 16, 2024
kripken
reviewed
Dec 16, 2024
sbc100
force-pushed
the
with_all_fs
branch
3 times, most recently
from
f59bf86 to
93b7e51
Compare
kripken
reviewed
Dec 16, 2024
I think in almost all of these cases I'm not adding more test variants here, just converting existing variants to use the decorators instead. There may be one or two where I increased it. I agree we might want to move all of these highly-parameterized FS tests to other. Perhaps as a followup. |
kripken
approved these changes
Dec 17, 2024
sbc100
force-pushed
the
with_all_fs
branch
2 times, most recently
from
85a7325 to
1fec631
Compare
hoodmane
reviewed
Dec 17, 2024
…ackends - @with_all_fs - @also_with_nodefs - @also_with_nodefs_both
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…ds (emscripten-core#23177) - @with_all_fs - @also_with_nodefs - @also_with_nodefs_both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.