[test] Remove also_with_wasmfs_js. NFC #23185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Dec 16, 2024
The only different here with `also_with_wasmfs` was that this decorator adds `FORCE_FILESYSTEM`, but the only test to use this decorator was already adding this flag.
sbc100
force-pushed
the
also_with_wasmfs_js
branch
from
0cf2f62 to
784c02d
Compare
kripken
approved these changes
Dec 16, 2024
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
The only different here with `also_with_wasmfs` was that this decorator adds `FORCE_FILESYSTEM`, but the only test to use this decorator was already adding this flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only different here with
also_with_wasmfswas that this decorator addsFORCE_FILESYSTEM, but the only test to use this decorator was already adding this flag.