Automatic rebaseline of codesize expectations. NFC #23188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (5) test expectation files were updated by running the tests with `--rebaseline`: browser/test_small_js_flags.js.size: 4369 => 4345 [-24 bytes / -0.55%] other/test_INCOMING_MODULE_JS_API.js.size: 3780 => 3758 [-22 bytes / -0.58%] other/test_unoptimized_code_size.js.size: 53980 => 53979 [-1 bytes / -0.00%] other/test_unoptimized_code_size_no_asserts.js.size: 29400 => 29399 [-1 bytes / -0.00%] other/test_unoptimized_code_size_strict.js.size: 52776 => 52775 [-1 bytes / -0.00%] Average change: -0.23% (-0.58% - -0.00%)
|
This is the first use of this script. WDYT? Perhaps we could format the results for easier readability? Maybe in table? |
kripken
approved these changes
Dec 17, 2024
|
Putting the automatic output in triple-quotes, so the font is fixed-size, would be good I think. |
|
Wouldn't it be good to run |
Yes we should have an option for that! |
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…3188) This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (5) test expectation files were updated by running the tests with `--rebaseline`: ``` browser/test_small_js_flags.js.size: 4369 => 4345 [-24 bytes / -0.55%] other/test_INCOMING_MODULE_JS_API.js.size: 3780 => 3758 [-22 bytes / -0.58%] other/test_unoptimized_code_size.js.size: 53980 => 53979 [-1 bytes / -0.00%] other/test_unoptimized_code_size_no_asserts.js.size: 29400 => 29399 [-1 bytes / -0.00%] other/test_unoptimized_code_size_strict.js.size: 52776 => 52775 [-1 bytes / -0.00%] Average change: -0.23% (-0.58% - -0.00%) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic change generated by tools/maint/rebaseline_tests.py.
The following (5) test expectation files were updated by running the tests with
--rebaseline: