rebaseline_tests.py: Add --new-branch and --clear. NFC #23192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
rebaseline_script
branch
from
c38e300 to
72f59d3
Compare
aheejin
approved these changes
Dec 17, 2024
kripken
reviewed
Dec 17, 2024
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('-s', '--skip-tests', action='store_true', help="don't actually run the tests, just analyze the existing results") | ||
| parser.add_argument('-b', '--new-branch', action='store_true', help='create a new branch containing the updates') | ||
| parser.add_argument('-c', '--clear-cache', action='store_true', help='clear the cache before rebaselining (useful when working with llvm changes)') |
There was a problem hiding this comment.
Should this be the default perhaps?
There was a problem hiding this comment.
I think most of the time this script will be used to update expectations in response for local emscripten changes (i.e. minor changes to JS libraries) not upstream llvm change. At least for me I often run rebases without clearing the cache when I know llvm has not changed.
There was a problem hiding this comment.
It also makes it much slower if you clear the cache first, and when this script runs in CI it would never be needed (since CI libs are always built using tot anyway).
kripken
reviewed
Dec 17, 2024
sbc100
force-pushed
the
rebaseline_script
branch
from
72f59d3 to
a14a73d
Compare
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.