CI: Check that test expectations are up-to-date #23201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
check_expectations
branch
21 times, most recently
from
7252f97 to
98bcecd
Compare
kripken
reviewed
Dec 17, 2024
sbc100
force-pushed
the
check_expectations
branch
from
98bcecd to
417fa17
Compare
sbc100
force-pushed
the
check_expectations
branch
3 times, most recently
from
a83b74b to
5cfa098
Compare
sbc100
force-pushed
the
check_expectations
branch
from
5cfa098 to
22a1448
Compare
|
Updated, and added some more context to the description. |
sbc100
force-pushed
the
check_expectations
branch
from
23b202d to
ea4940d
Compare
|
Sounds good, if this is just a recommendation then I am not worried about annoyance. |
Its just a recommendation ... for now :) We can chat more about the next steps we might want to build on top of this. |
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
This test will fail if the expectations are out-of-date on the main branch. This can happen due to either: 1. Somebody forgetting to update the expectations when they land an emscripten change 2. llvm or binaryen changes that rolled in on the auto-roller. For now I propose that we don't make this new check "Required" and we consider this the first step towards making these updates easy and automatic. I made this a github action rather than using CiricleCI since I anticipate using github automation here in the future (for example to suggest updates the current PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will fail if the expectations are out-of-date on the main branch. This can happen due to either:
For now I propose that we don't make this new check "Required" and we consider this the first step towards making these updates easy and automatic.
I made this a github action rather than using CiricleCI since I anticipate using github automation here in the future (for example to suggest updates the current PR).