Remove pinned version of lxml from requirements-dev.txt. NFC #23204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like the underlying issue with the mac package has been fixes somehow, and I was running into issues with this version of lxml not being installable on python 3.12 (which is in ubuntu-latest on github CI). See emscripten-core#19785
dschuff
approved these changes
Dec 17, 2024
hedwigz
pushed a commit
to hedwigz/emscripten
that referenced
this pull request
Dec 18, 2024
…ten-core#23204) It seems like the underlying issue with the mac package has been fixes somehow, and I was running into issues with this version of lxml not being installable on python 3.12 (which is in ubuntu-latest on github CI). See emscripten-core#19785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the underlying issue with the mac package has been fixes somehow, and I was running into issues with this version of lxml not being installable on python 3.12 (which is in ubuntu-latest on github CI).
See #19785