Skip to content

Conversation

@hoodmane
Copy link
Collaborator

@hoodmane hoodmane commented Jan 6, 2025

It cannot support this since node doesn't support it. So we should tell the truth that we can't do it instead of ignoring it.

@hoodmane
Copy link
Collaborator Author

hoodmane commented Jan 9, 2025

I realized this has no interaction with #23058 so I moved it off of that and now the diff here is quite small @sbc100.

@hoodmane hoodmane merged commit 675698d into emscripten-core:main Jan 9, 2025
28 of 29 checks passed
@hoodmane hoodmane deleted the symlink-no-follow branch January 9, 2025 19:40
@sbc100
Copy link
Collaborator

sbc100 commented Jan 9, 2025

Looks like this was missing the code size updates. I'll land an update now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants