-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[AUDIO_WORKLET] Wait for Wasm instance to start using audio worklet. #24734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,10 +11,7 @@ if (runtimeInitialized) { | |
moduleRtn = Module; | ||
} else { | ||
// Set up the promise that indicates the Module is initialized | ||
moduleRtn = new Promise((resolve, reject) => { | ||
readyPromiseResolve = resolve; | ||
readyPromiseReject = reject; | ||
}); | ||
moduleRtn = readyPromise = createReadyPromise(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we just do There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think if I do that, I'll have to undo the work you did in https://github.com/emscripten-core/emscripten/pull/24418/files and add back a try/catch. |
||
} | ||
#else | ||
moduleRtn = {}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can perhaps remove the question marks here too. i.e. we can make USE_READY_PROMISE imply that readyPromiseResolve exists?